Introduce fuzz tests for docker file logs parsing by blt · Pull Request #38733 · DataDog/datadog-agent

blt · 2025-07-11T18:56:15Z

What does this PR do?

This commit introduces new fuzz tests for
pkg/logs/internal/parsers/dockerfile. I have not found any panics or crashes
but I have clarified the newline stripping around examples like \n\n.

Peer to:

Motivation

Increase fuzz coverage of Agent.

blt · 2025-07-11T18:56:39Z

Introduce fuzz tests for docker file logs parsing #38733 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

michaelcretzman

Approved with one suggested fix.

cit-pr-commenter · 2025-07-11T19:49:25Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c80ccf21-5795-433e-bed0-7bc9d233dd74

Baseline: 83af8f5
Comparison: d7454a0
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.50	[-5.55, +0.54]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.98	[+0.21, +5.75]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+1.00	[+0.93, +1.06]	1	Logs
➖	ddot_logs	memory utilization	+0.58	[+0.49, +0.67]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.48	[+0.37, +0.58]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.41	[-0.45, +1.27]	1	Logs
➖	docker_containers_memory	memory utilization	+0.41	[+0.36, +0.47]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.14	[-0.00, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.11	[-0.48, +0.71]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.06	[-0.06, +0.18]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.04	[-0.59, +0.68]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.02	[-0.57, +0.61]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.27, +0.28]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.00	[-0.05, +0.05]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	ddot_metrics	memory utilization	-0.02	[-0.13, +0.10]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.12	[-0.70, +0.47]	1	Logs
➖	file_tree	memory utilization	-0.20	[-0.25, -0.15]	1	Logs
➖	quality_gate_idle	memory utilization	-0.29	[-0.36, -0.21]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-2.50	[-5.55, +0.54]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

This commit introduces new fuzz tests for `pkg/logs/internal/parsers/dockerfile`. I have not found any panics or crashes but I have clarified the newline stripping around examples like `\n\n`. Peer to: * #38628 * #38579 * #38724 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

…49a4d99016.yaml Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>

blt · 2025-07-11T20:55:48Z

/merge

dd-devflow-routing-codex · 2025-07-11T20:55:52Z

View all feedbacks in Devflow UI.

2025-07-11 20:55:52 UTC ℹ️ Start processing command /merge

2025-07-11 20:56:01 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-11 21:39:11 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-07-11 22:13:47 UTC ℹ️ MergeQueue: This merge request was merged

agent-platform-auto-pr · 2025-07-11T21:26:37Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7626bfe

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${702.71}$$ < $${703.45}$$	$${-0.01}$$	$${177.41}$$ < $${178.35}$$
✅	agent_deb_amd64_fips	$${0}$$	$${700.96}$$ < $${701.7}$$	$${+0}$$	$${176.76}$$ < $${177.76}$$
✅	agent_heroku_amd64	$${0}$$	$${354.35}$$ < $${355.37}$$	$${+0}$$	$${94.76}$$ < $${95.72}$$
✅	agent_msi	$${0}$$	$${977.17}$$ < $${978.18}$$	$${-0}$$	$${148.45}$$ < $${149.26}$$
✅	agent_rpm_amd64	$${0}$$	$${702.7}$$ < $${703.44}$$	$${-0.01}$$	$${178.9}$$ < $${179.87}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${700.95}$$ < $${701.69}$$	$${-0.01}$$	$${178.55}$$ < $${179.47}$$
✅	agent_rpm_arm64	$${0}$$	$${692.72}$$ < $${693.48}$$	$${-0.03}$$	$${162.66}$$ < $${163.62}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${691.03}$$ < $${691.79}$$	$${-0.03}$$	$${161.71}$$ < $${162.65}$$
✅	agent_suse_amd64	$${0}$$	$${702.7}$$ < $${703.44}$$	$${-0.01}$$	$${178.9}$$ < $${179.87}$$
✅	agent_suse_amd64_fips	$${0}$$	$${700.95}$$ < $${701.69}$$	$${-0.01}$$	$${178.55}$$ < $${179.47}$$
✅	agent_suse_arm64	$${0}$$	$${692.72}$$ < $${693.48}$$	$${-0.03}$$	$${162.66}$$ < $${163.62}$$
✅	agent_suse_arm64_fips	$${0}$$	$${691.03}$$ < $${691.79}$$	$${-0.03}$$	$${161.71}$$ < $${162.65}$$
✅	docker_agent_amd64	$${+0}$$	$${786.52}$$ < $${787.26}$$	$${-0}$$	$${270.59}$$ < $${271.51}$$
✅	docker_agent_arm64	$${0}$$	$${799.98}$$ < $${800.74}$$	$${+0}$$	$${258.32}$$ < $${259.24}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${977.71}$$ < $${978.45}$$	$${+0}$$	$${339.56}$$ < $${340.47}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${979.77}$$ < $${980.54}$$	$${+0.01}$$	$${323.29}$$ < $${324.2}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${213.72}$$ < $${214.5}$$	$${-0}$$	$${72.63}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${229.56}$$ < $${230.33}$$	$${+0}$$	$${68.9}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${39.24}$$ < $${39.57}$$	$${-0}$$	$${15.12}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.88}$$ < $${38.2}$$	$${+0}$$	$${14.55}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.0}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.01}$$ < $${29.97}$$	$${-0}$$	$${6.95}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${53.88}$$ < $${54.55}$$	$${+0}$$	$${13.58}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${51.21}$$ < $${51.9}$$	$${+0}$$	$${11.75}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${50.72}$$ < $${51.42}$$	$${-0.01}$$	$${11.85}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${53.88}$$ < $${54.55}$$	$${-0}$$	$${13.59}$$ < $${14.47}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${51.21}$$ < $${51.91}$$	$${+0}$$	$${11.77}$$ < $${12.65}$$
✅	iot_agent_suse_amd64	$${0}$$	$${53.88}$$ < $${54.55}$$	$${-0}$$	$${13.59}$$ < $${14.47}$$

github-actions Bot added team/agent-log-pipelines medium review PR review might take time labels Jul 11, 2025

blt added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog No changelog entry needed labels Jul 11, 2025 — with Graphite App

blt marked this pull request as ready for review July 11, 2025 18:57

blt requested a review from a team as a code owner July 11, 2025 18:57

blt force-pushed the blt/docker_file_fuzz branch from 263e7a5 to cbbe6ac Compare July 11, 2025 19:02

blt removed qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog No changelog entry needed labels Jul 11, 2025

blt requested a review from a team as a code owner July 11, 2025 19:05

blt added the qa/skip-qa label Jul 11, 2025

jszwedko approved these changes Jul 11, 2025

View reviewed changes

michaelcretzman approved these changes Jul 11, 2025

View reviewed changes

Comment thread releasenotes/notes/Fix-panic-in-docker-file-log-parsing-22175d49a4d99016.yaml Outdated

blt and others added 3 commits July 11, 2025 13:03

add releasenote

ab8f686

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

Update releasenotes/notes/Fix-panic-in-docker-file-log-parsing-22175d…

d7454a0

…49a4d99016.yaml Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>

blt force-pushed the blt/docker_file_fuzz branch from c17177a to d7454a0 Compare July 11, 2025 20:04

blt added the qa/done QA done before merge and regressions are covered by tests label Jul 11, 2025

dd-mergequeue Bot merged commit dfa50d6 into main Jul 11, 2025
259 of 260 checks passed

dd-mergequeue Bot deleted the blt/docker_file_fuzz branch July 11, 2025 22:13

github-actions Bot added this to the 7.70.0 milestone Jul 11, 2025

Navigation Menu

Uh oh!

Introduce fuzz tests for docker file logs parsing - #38733

Introduce fuzz tests for docker file logs parsing#38733
dd-mergequeue[bot] merged 3 commits into
mainfrom
blt/docker_file_fuzz

blt commented Jul 11, 2025 •

edited

Loading

Uh oh!

blt commented Jul 11, 2025

Uh oh!

michaelcretzman left a comment

Uh oh!

Uh oh!

cit-pr-commenter Bot commented Jul 11, 2025 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

blt commented Jul 11, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Jul 11, 2025 •

edited

Loading

Info

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

blt commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Uh oh!

blt commented Jul 11, 2025

Uh oh!

michaelcretzman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cit-pr-commenter Bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

blt commented Jul 11, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-platform-auto-pr Bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blt commented Jul 11, 2025 •

edited

Loading

cit-pr-commenter Bot commented Jul 11, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Jul 11, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Jul 11, 2025 •

edited

Loading